[ML] Don't block thread while waiting for work to finish on graceful shutdown #135350
+91
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/inference/assignment/TrainedModelAssignmentNodeService.java # x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/inference/assignment/TrainedModelAssignmentNodeServiceTests.java
...plugin/ml/src/main/java/org/elasticsearch/xpack/ml/inference/deployment/ShutdownTracker.java
Outdated
Show resolved
Hide resolved
|
Pinging @elastic/ml-core (Team:ML) |
...ugin/ml/src/main/java/org/elasticsearch/xpack/ml/inference/deployment/DeploymentManager.java
Outdated
Show resolved
Hide resolved
jonathan-buttner
approved these changes
Sep 30, 2025
davidkyle
added
the
cloud-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A model deployment that is gracefully shutdown will wait until the queue up work is done (or timeout) before terminating the inference process. Waiting for the work to complete should not block a thread as it may be blocked for up to 5 minutes. The change here adds a call back to the worker queue to terminate the process once it has completed.
Follow on from #134673